didn't journal a failed credit card transaction as successfully occurring and then create a second journal entry to reverse the transaction
If a credit card transaction failed, there is no positive transaction - and without it no need for the reversal. A single non-monetary journal transaction showing that the failed transaction should suffice.
The two offsetting transactions that are currently being recorded create a myriad of problems from a querying and reporting standpoint. And from a strict accounting standpoint, in my opinion, it is wrong. A failed credit card transaction is not a gift that needs to be reversed; a failed credit card transaction is a gift that didn't happen.